On Thu, Mar 15, 2018 at 08:01:45AM +1100, Dave Chinner wrote: > On Wed, Mar 14, 2018 at 05:19:01PM +0000, Luis R. Rodriguez wrote: > > On Wed, Mar 14, 2018 at 02:55:31PM +1100, Dave Chinner wrote: > > > On Tue, Mar 13, 2018 at 11:52:27PM +0000, Luis R. Rodriguez wrote: > > > > On Wed, Mar 14, 2018 at 08:39:16AM +1100, Dave Chinner wrote: > > > > > > Basically: > > > > > > 1. the default file parsing code needs to go into it's own file. > > > xfs_mkfs.c is too large and needs to be split into smaller files, so > > > lets not make it worse by shovelling another 500 lines of code into > > > it... > > > > Sure. Other than using its own file you had suggested to have the config stuff have its own structure. At LSFMM you had also suggested it should have its own defaults which may change later, however for now they can be the same as the CLI defaults. I suspect likewise applies for maxval, minval. What about the conflict mapping / checkers? Don't we want to share that? If so it would make sense to share the enums used to describe the individual subopts as well. If so I'll shove the enums into its own file. The conflict stuff is already in its own structure, so if we want to *share* that, I could just move all that into its own set of files and share that. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
