On Mon, Apr 23, 2018 at 07:23:46PM +0200, Christoph Hellwig wrote: > > +int > > +xfs_qm_dqget_inode( > > + struct xfs_mount *mp, > > As pointed out by Brian, we can skip passing this argument. > > > + struct xfs_inode *ip, > > + uint type, > > + uint can_alloc, > > can_alloc should probably be a bool, or passing XFS_QMOPT_DQALLOC > directly. Later I just turn it into a 'dqmode' argument where you can pass XFS_DQGET_ALLOC (read or alloc on-disk dquot) or XFS_DQGET_EXISTS (read from disk, error out if it's not there). It's tempting to make those an enum xfs_dqget_mode to enforce that, maybe I'll send that as a patch 14. --D > > Otherwise looks fine: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
