On Sun, Apr 22, 2018 at 08:05:58AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > There's only one caller of DQNEXT and its semantics can be moved into a > separate function, so create the function and get rid of the flag. Is there any good reason to keep the xfs_qm_scall_getquota{,next} helpers instead of simplify factoring them into their only caller? Otherwise this looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html