On Tue, Apr 17, 2018 at 07:39:39PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Create a new QMOPT flag to signal that we've already locked the quota > inode. This will be used by the quota scrub code refactoring to avoid > dropping the quota ip lock during scrub. The flag is incompatible with > the DQALLOC flag because dquot allocation creates a transaction, and we > shouldn't be doing that with the ILOCK held. Locked flag are always a sign for code smell. And this already is pretty smelly code before that flag is added. I think someone (i.e. either you or me :)) needs to do a major refactoring here first. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html