On Wed, Apr 18, 2018 at 08:24:42AM -0700, Darrick J. Wong wrote: > On Wed, Apr 18, 2018 at 01:46:58PM +0200, Carlos Maiolino wrote: > > On Wed, Apr 18, 2018 at 10:21:10AM +1000, Dave Chinner wrote: > > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > > > Move xfs_buf_incore out of line and make it the only way to look up > > > a buffer in the buffer cache from outside the buffer cache. Convert > > > the external users of _xfs_buf_find() to xfs_buf_incore() and make > > > _xfs_buf_find() static. > > > > > > > Looks good, but shouldn't it be xfs_incore() instead of xfs_buf_incore() in the > > Subject/description? > > I wonder if this function really should be named xfs_buf_incore because > xfs maintains a lot of incore state besides buffers, but as far as this > patch goes I'll fix the commit message on the way in. I think I intended to rename it xfs_buf_incore() in this patch, but got distracted between writing the commit message (I almost always do that first) and then making the change. ANd so I forgot to s/xfs_incore/xfs_buf_incore. Do you want me to resend? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
