> } else if (mode & FALLOC_FL_INSERT_RANGE) { > unsigned int blksize_mask = i_blocksize(inode) - 1; > + loff_t isize; > > + isize = i_size_read(inode); Maybe move the assignment up: loff_t isize = i_size_read(inode); But functionally this looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html