On Fri, Apr 06, 2018 at 09:02:18AM +1000, Dave Chinner wrote: > On Mon, Apr 02, 2018 at 12:56:31PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Add a couple of functions to the reverse mapping btree that will be used > > to repair the rmapbt. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Minor nit: > > > +struct xfs_rmap_key_state { > > + uint64_t owner; > > + uint64_t offset; > > + unsigned int flags; > > + bool has_rmap; > > +}; > > + > > +/* For each rmap given, figure out if it doesn't match the key we want. */ > > +STATIC int > > +xfs_rmap_has_other_keys_helper( > > + struct xfs_btree_cur *cur, > > + struct xfs_rmap_irec *rec, > > + void *priv) > > +{ > > + struct xfs_rmap_key_state *rhok = priv; > > rks rather than rhok? Yep yep, fixed. --D > > Otherwise looks ok. > > Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> > > -- > Dave Chinner > david@xxxxxxxxxxxxx > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html