On 4/5/18 5:40 PM, Dave Chinner wrote: > On Wed, Apr 04, 2018 at 11:13:03PM -0500, Eric Sandeen wrote: >> On 4/4/18 10:52 PM, Darrick J. Wong wrote: >>> On Wed, Apr 04, 2018 at 01:54:26PM -0500, Eric Sandeen wrote: >>>> In order to validate the UUID in xfs_dquot_verify, we need >>>> the full xfs_qblk, not just the xfs_disk_dquot_t (which is >>> >>> ^^^^^^^^^ xfs_dqblk, right? >> >> yup >> >> ... >> >>>> @@ -192,14 +191,10 @@ >>> >>> Any way you can get your diff generator to add -p to spit out the >>> alleged function this chunk is supposed to land in? It makes reviewing >>> patches somewhat easier for me. :) >> >> No doubt ... I don't know why it doesn't do so, sorry. :/ Will try >> to figure that out. Sorry about that. > > diff -up I am actually familiar with diff, thanks ;) I couldn't figure out why git & guilt weren't giving me the expected results. For some reason I had this in this particular repo: $ cat .gitattributes *.c diff=cpp *.h diff=cpp Getting rid of that fixes it, I don't actually know why it was there. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
