Re: [PATCH] xfs: factor out xfs_dquot_verify_crc for use in quotacheck rebuild

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/3/18 5:19 PM, Eric Sandeen wrote:
> Today, if a quota block has a bad UUID or CRC, it will never get
> rebuilt or repaired.
> 
> xfs_repair does not check or validate quota blocks, leaving that task
> to in-kernel quotacheck.  In-kernel quotacheck does not validate the
> UUID or CRC.  So the problem remains indefinitely.
> 
> To remedy this:
> 
> * Factor out xfs_dquot_verify_crc from xfs_dquot_buf_verify_crc
> * Call this new function from xfs_qm_reset_dqcounts for V5 fs
> 
> If an invalid UUID or CRC is found, this will trigger xfs_dquot_repair
> which rewrites them.
> 
> Also, since xfs_dquot_repair() operates on the disk block, just
> send that in directly since we have it handy.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Actually don't bother with this one just yet, working on a V2 that
deals with UUIDs directly and doesn't wrap it up in the CRC check
(which doesn't quite make sense logically ... I think)

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux