On Wed 21-03-18 15:57:27, Dan Williams wrote: > Block device inodes never have S_DAX set, so kill the check for DAX and > diversion to dax_writeback_mapping_range(). > > Cc: Jeff Moyer <jmoyer@xxxxxxxxxx> > Cc: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx> > Cc: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx> > Cc: Jan Kara <jack@xxxxxxx> > Cc: Dave Chinner <david@xxxxxxxxxxxxx> > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx> Looks good. You can add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza > --- > fs/block_dev.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/fs/block_dev.c b/fs/block_dev.c > index fe09ef9c21f3..846ee2d31781 100644 > --- a/fs/block_dev.c > +++ b/fs/block_dev.c > @@ -1946,11 +1946,6 @@ static int blkdev_releasepage(struct page *page, gfp_t wait) > static int blkdev_writepages(struct address_space *mapping, > struct writeback_control *wbc) > { > - if (dax_mapping(mapping)) { > - struct block_device *bdev = I_BDEV(mapping->host); > - > - return dax_writeback_mapping_range(mapping, bdev, wbc); > - } > return generic_writepages(mapping, wbc); > } > > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html