On Wed, Mar 28, 2018 at 10:15:09AM +1100, Dave Chinner wrote: > On Mon, Mar 26, 2018 at 04:56:32PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Rebuilding the reverse-mapping tree requires us to quiesce all inodes in > > the filesystem, so we must stop background reclamation of post-EOF and > > CoW prealloc blocks. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > We also do the same thing during remount and unmount, so these > helpers should be used in those places, too. > > And, thinking about it - if the filesystem is frozen then we should > also be cancelling this background work and re-enabling it on > thaw. Seems like we've missed that altogether... Yeah, I was wondering about whether these reclaim bits could fire up on a frozen filesystem. I'll try toggling reclaim during freeze/umount a shot, which means we won't have to do it in the rmapbt repair patch. --D > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
