On Fri, Mar 23, 2018 at 09:08:17AM -0700, Darrick J. Wong wrote: > > > + > > > + # Format filesystem > > > + echo "TEST $cmd" | tee /dev/ttyprintk > > > > What's the purpose of writing to /dev/ttyprintk? I don't see how it's > > used in the test. > > It makes it easy to tell which kernel messages came from which runtest() > invocation so that we can tell if a particular agfl mutation test > actually triggered the fixup. This could fail the test if /dev/ttyprintk doesn't exist. It seems writing to /dev/kmsg works could tell us the same information, and we've already made sure /dev/kmsg is writable by _require_check_dmesg. IMHO /dev/kmsg might be a better choice here. Thanks, Eryu -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
