On Fri, Mar 23, 2018 at 3:37 AM, Eric Sandeen <sandeen@xxxxxxxxxxx> wrote:
>> +function ensure_not_mounted() {
>> + local dev=$1
>> + mounted=`grep -c "^$dev " /proc/mounts`
>> + if [ $mounted -ne 0 ]; then
>> + echo "$NAME error: The filesystem to be checked must not be mounted." 1>&2
>> + exit 4
>> + fi
>> +}
>
> Is this necessary? Doesn't xfs_repair already check this?
>
> # xfs_repair /dev/loop0
> xfs_repair: /dev/loop0 contains a mounted filesystem
> xfs_repair: /dev/loop0 contains a mounted and writable filesystem
>
> fatal error -- couldn't initialize XFS library
>
> # echo $?
> 1
>
> (script would then say "error: xfs_repair could not fix the filesystem."
> and exit with 4.)
>
> It might be nice to have the cleaner message above, but I wonder about
> the wisdom and safety of hand-rolling another simplistic mount check in a bash
> script.... thoughts?
>
Mmm, we are not hiding the message, so I guess it doesn't really
matter, the xfs_repair errors are going to be visible. This testing
remained there from when I wanted to use another exit code for mounted
fs and xfs_repair failures. But I'm removing the check now, with the
merged exit code it is not useful.
Other stuff: ok, changed.
Thanks,
Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
