>
> Note that this crash is only possible on v4 filesystemsi or v5
> filesystems mounted with the ikeep mount option. For all other V5
> filesystems, this problem cannot occur because we don't read inodes
> we are allocating from disk - we simply overwrite them with the new
> inode information.
>
> Signed-Off-By: Dave Chinner <dchinner@xxxxxxxxxx>
I could reproduce this problem by manually setting an inode as free in the
inobt, and the patch fixes the bug.
The patch looks good too.
xfstests should hit the list soon.
Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Tested-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
> ---
> fs/xfs/xfs_icache.c | 23 ++++++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> index 1dc37b72b6ea..98b7a4ae15e4 100644
> --- a/fs/xfs/xfs_icache.c
> +++ b/fs/xfs/xfs_icache.c
> @@ -484,7 +484,28 @@ xfs_iget_cache_miss(
>
> trace_xfs_iget_miss(ip);
>
> - if ((VFS_I(ip)->i_mode == 0) && !(flags & XFS_IGET_CREATE)) {
> +
> + /*
> + * If we are allocating a new inode, then check what was returned is
> + * actually a free, empty inode. If we are not allocating an inode,
> + * the check we didn't find a free inode.
> + */
> + if (flags & XFS_IGET_CREATE) {
> + if (VFS_I(ip)->i_mode != 0) {
> + xfs_warn(mp,
> +"Corruption detected! Free inode 0x%llx not marked free on disk",
> + ino);
> + error = -EFSCORRUPTED;
> + goto out_destroy;
> + }
> + if (ip->i_d.di_nblocks != 0) {
> + xfs_warn(mp,
> +"Corruption detected! Free inode 0x%llx has blocks allocated!",
> + ino);
> + error = -EFSCORRUPTED;
> + goto out_destroy;
> + }
> + } else if (VFS_I(ip)->i_mode == 0) {
> error = -ENOENT;
> goto out_destroy;
> }
> --
> 2.16.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Carlos
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
