On 3/22/18 5:05 PM, Eric Sandeen wrote: > On 3/16/18 1:08 AM, Baruch Siach wrote: ... >>> Our convention within xfsprogs sources (I think) is for most header >>> files to avoid having headers include other headers. Would you mind >>> adding this include to read_verify.c instead? >> >> I don't mind. But requiring every user of workqueue.h to remember to have >> pthread.h before, is error prone IMO. >> >>> (That said, you probably ought to wait for the maintainer (Eric) to >>> weigh in on this before you do any more work.) > > Sorry for the late reply. > > Eh, I think I'm inclined to just take this as-is, I don't see a downside to it. Actually now I'm on the fence, half of scrub already includes pthread.h directly :/ How many C files would need to include pthread.h to get the build going? And, um, how can we get ourselves out of this "break musl, rinse, repeat" cycle? -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
