Re: [PATCH v6 07/15] fs, dax: use page->mapping to warn if truncate collides with a busy page

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dan,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.16-rc5 next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Dan-Williams/dax-fix-dma-vs-truncate-hole-punch/20180318-050250
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All error/warnings (new ones prefixed by >>):

   fs/dax.c: In function 'dax_entry_size':
>> fs/dax.c:308:10: error: 'HPAGE_SIZE' undeclared (first use in this function); did you mean 'PAGE_SIZE'?
      return HPAGE_SIZE;
             ^~~~~~~~~~
             PAGE_SIZE
   fs/dax.c:308:10: note: each undeclared identifier is reported only once for each function it appears in
>> fs/dax.c:311:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +308 fs/dax.c

   300	
   301	static unsigned long dax_entry_size(void *entry)
   302	{
   303		if (dax_is_zero_entry(entry))
   304			return 0;
   305		else if (dax_is_empty_entry(entry))
   306			return 0;
   307		else if (dax_is_pmd_entry(entry))
 > 308			return HPAGE_SIZE;
   309		else
   310			return PAGE_SIZE;
 > 311	}
   312	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux