On Thu, Mar 15, 2018 at 7:11 PM, Darrick J. Wong <darrick.wong@xxxxxxxxxx> wrote: >> + >> +if $FORCE; then >> + if [ -f /sbin/xfs_repair ]; then >> + BIN="/sbin/xfs_repair" >> + elif [ -f /usr/sbin/xfs_repair ]; then >> + BIN="/usr/sbin/xfs_repair" > > Can we just run xfs_repair and assume it's in the PATH? Because not every distro has bundled xfs_repair into initramfs, I would rather expect that they can forget to add it after this patch than have an unexpected failure. Other points are ok, I'm sending the patches... Thanks, Jan -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html