On Wed, Mar 14, 2018 at 08:25:04AM -0700, Darrick J. Wong wrote: > On Wed, Mar 14, 2018 at 02:51:51PM +0100, Jan Tulak wrote: > > On Thu, Mar 8, 2018 at 11:36 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > > >> > - if the volume/device has a dirty log, exit with 4 - errors left > > >> > uncorrected (drop to the shell) > > > > > > Yup. > > > > > >> > - if we find no errors, exit with 0 - no errors > > > > > > Yup, but only if the filesystem is not mounted, otherwise it's > > > "requires reboot" because repair with no errors still rewrites all > > > the per-ag metadata and so changes the on disk metadata layout. > > > Continuing at this point with a mounted filesystem is guaranteed to > > > corrupt the filesystem. > > > > We refuse to start with a mounted fs, so this is no issue. > > > > > > > >> > - if we find anything and xfs_repair ends successfully, exit with 1 - > > >> > errors corrected > > > > > > Same as the above case - needs reboot. > > > > Do we? The fs wasn't mounted at this point yet. Maybe there is a > > reason for a reboot, I just don't know about it. :-) > > I agree that it's fine to move on to mounting the rootfs provided we > don't do -d. Right, my was "same as the above case" where I said: | Yup, but only if the filesystem is not mounted, otherwise it's | "requires reboot" -Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
