Re: [PATCH 8/8] xfs: only clear preallocated COW blocks in xfs_reflink_clear_inode_flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 13, 2018 at 01:56:04PM -0700, Darrick J. Wong wrote:
> On Tue, Mar 13, 2018 at 03:36:01PM +0100, Christoph Hellwig wrote:
> > Currently these are the only ones that should exist at this point anyway,
> > but with O_ATOMIC writes we might have legit extents around in the COW
> > fork even when clearing the reflink flag.
> 
> Hmmm... so I assume that the premise of the O_ATOMIC write series is
> still that we use the cow fork to stage writes until fsync, and the
> presence of a cow fork is now separate from the reflink inode flag?

Yes.
> 
> Therefore, it's perfectly legit to have a !reflink inode with real
> extents sitting in the cow fork and legit to be clearing the reflink
> iflag with real extents sitting around.
> 
> I think this is ok but I'd sure like to see the atomic writes patches
> before I pull this one in.

Ok.  Skip if for now then.
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux