On Tue, Mar 06, 2018 at 03:54:08PM -0600, Eric Sandeen wrote: > We test the return value of this macro, but it returns > a side-effect which looks like failure. Write a > userspace-libxfs-specific version of xfs_buf_associate_memory > to make this code a tad more like the kernel, with a proper > return value to boot. Looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx> But aren't we supposed to just share xfs_log_recover.c (or the relevant parts of it) with the kernel anyway? -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html