On Wed, Mar 07, 2018 at 08:10:20PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > AN inode is joined to teh same transaction twice in > xfs_reflink_cancel_cow_range() resulting in the following assert > failure: Needs some major spelling love :) > > [ 30.180485] XFS: Assertion failed: !(lip->li_flags & XFS_LI_TRANS), file: fs/xfs/xfs_trans.c, line: 740 That assertations seems like something that only exists locally in your tree. Any chance to send it out with this series? The other option would be to make xfs_trans_ijoin a no-op if the inode is already joined, except that this wouldn't work with the magic unlock on commit. Which is a feature I find horribly confusing, so we should get rid of it, for which we'd need to get rid of the concept of synchronous transactions in favour of leaving the log force to the caller, which again would be more logical. Guess I need to look into doing these cleanups as I don't want to force them on anyone else. Just need to finish all the other more important bits on the todo list first :) -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
