On 3/6/18 1:32 PM, Eric Sandeen wrote: > On 3/1/18 1:14 PM, Darrick J. Wong wrote: >> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> >> >> Add an 'info' command to pretty-print the superblock geometry. > I'm on the fence about this; xfs_db generally just dumps representations > of individual disk structures. This seems like a bit of an expansion of > its charter. What is the use case for this? Convince me that it's good > to add this code? > > Thanks, > -Eric > Sorry - of course later patches make xfs_info work offline, but still, I'd like to see some rationale for why we need that capability. I'm all for the code reduction of the common printing routine but what's the big picture rational for teaching all these other tools to print mkfs-like output? Thanks, -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
