Re: [PATCH] xfs_scrub: make interpreter explicit to python3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 02, 2018 at 10:08:42AM +0100, Carlos Maiolino wrote:
> On Thu, Mar 01, 2018 at 10:05:09PM -0600, Eric Sandeen wrote:
> > 
> > 
> > On 2/23/18 10:40 PM, Darrick J. Wong wrote:
> > > On Fri, Feb 23, 2018 at 06:15:12PM -0800, Luis R. Rodriguez wrote:
> > >> Using #!/usr/bin/env makes some package dependency tools
> > >> such as rpm complain given that it cannot verify package
> > >> dependencies. Making it explicit resolves this lint rant.
> > >>
> > >> Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx>
> > > 
> > > Looks ok,
> > > Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> > 
> > intereting, my rpmbuild actually converts this on the fly.  ;)
> > But fine by me to hardcode it if Darrick says ok.  :)
> > 
> 
> Just a question though about this.
> 
> What if somebody/somedistro installs python3 on another $PATH?
> 
> It's been a while since I don't do any packaging stuff, so, I just wonder if
> this couldn't cause issues on distros using different install paths?

They can always patch in the path to their python3 executable.

Though, given the number of /usr/bin/python3 scripts floating around in
Google, I'm guessing a distro would have to have a really good reason to
put it elsewhere.

--D

> Cheers.
> 
> > Thanks,
> > -Eric
> > 
> > > --D
> > > 
> > >> ---
> > >>  scrub/xfs_scrub_all.in | 2 +-
> > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/scrub/xfs_scrub_all.in b/scrub/xfs_scrub_all.in
> > >> index fff05da3ea7a..80f07d5c8b02 100644
> > >> --- a/scrub/xfs_scrub_all.in
> > >> +++ b/scrub/xfs_scrub_all.in
> > >> @@ -1,4 +1,4 @@
> > >> -#!/usr/bin/env python3
> > >> +#!/usr/bin/python3
> > >>  
> > >>  # Run online scrubbers in parallel, but avoid thrashing.
> > >>  #
> > >> -- 
> > >> 2.16.2
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> -- 
> Carlos
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux