> On Feb 25, 2018, at 3:05 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > >> On Sun, Feb 25, 2018 at 12:11:28PM -0600, Eric Sandeen wrote: >> >> >>> On 2/25/18 12:09 PM, Darrick J. Wong wrote: >>> On Sun, Feb 25, 2018 at 12:11:23PM +0800, Chengguang Xu wrote: >>>>> >>>>> 在 2018年2月25日，上午1:58，Eric Sandeen <sandeen@xxxxxxxxxxx> 写道： >>>>> >>>>>> On 2/24/18 4:33 AM, Chengguang Xu wrote: >>>>>> When specifying string type mount option (e.g., logdev) >>>>>> several times in a mount, current option parsing may >>>>>> cause memory leak. Hence, call kfree for previous one >>>>>> in this case. >>>>>> >>>>>> Signed-off-by: Chengguang Xu <cgxu519@xxxxxxxxxx> >>>>> >>>>> IMHO multiple specifications of logdev or rtdev should not >>>>> be allowed; only one may be chosen, and specifying twice >>>>> should probably be considered and administrative error. >>>>> >>>>> I'd rather see something that fails and cleans up properly >>>>> if either option is respecified. >>>> >>>> Hi Eric, >>>> >>>> Thanks for quick reply. I think your suggestion makes sense, >>>> but considering of the consistency with other options, >>>> we should check multiple specifications for all options. >>>> >>>> So I think this patch is the cheapest way to fix the issue. >>>> What do you think? >>> >>> I think the all the mount options should be cleaned up to allow one >>> specification only. >> >> Yeah, I think so too, though perhaps it's fair to have one patch >> to fix the leak as it stands today, and another to clean up the >> respecification problem. > > Won't that break existing userspace configs? Haven't we had cases in > the past where mount did something whacky and passed dulicate > options to the kernel through no fault of the user? > Hmm perhaps on remount yes... worth testing / checking. Eric > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx > -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
