On 2/24/18 5:23 AM, Yang Joseph wrote: > hello, > > Before the repair process, xfs_repair will check if user specified device already > has a writable mountpoint. And it will stat all the mountpoints of the system. If there > is a dead mountpoint, this checking will be blocked and xfs_repair will enter 'D' state. > > So, if user can make sure there is no writable mountpoint, xfs_repair can skip > this checking. This PR add a new option '-F' to do this job. > > Your suggestions are appreciated! For starters, this patch seems whitespace mangled and does not apply for me. However, repairing a filesystem that is actually mounted read-write could cause serious damage. Giving the admin tools to do this carries significant risk; we already call it "dangerous" to repair even an ro-mounted filesystem. Do you have a testcase to produce a "dead" mountpoint which causes xfs_repair to go into "D" state? Where was xfs_repair stuck? That sounds like a bug worth fixing, but I am much less excited about adding options which could do serious damage to a filesystem. Thanks, -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
