On Mon, Feb 12, 2018 at 10:29:48AM -0800, Darrick J. Wong wrote: > On Mon, Feb 12, 2018 at 02:00:05PM +0100, Carlos Maiolino wrote: > > Remove unused legacy btree traces from IRIX era. > > > > Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx> > > --- > > > > Talking to Dave about it, he mentioned XFS_BTREE_TRACE_CURSOR might be worth to > > turn into a proper ftrace trace point, so I didn't touch _CURSOR traces in this > > patchset, and a proper conversion will be sent later, unless it's not worth at > > all, and I should send a V2 also removing TRACE_CURSOR. > > TBH I wonder the opposite -- why not turn all of these into tracepoints? TBH, we haven't used them in at least 15 years. What value do they provide apart from making the traces even noisier (and potentially more lossy) than they already are? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
