On 2/5/18 5:22 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>
> If the kernel doesn't have the SCRUB_METADATA ioctl that's a runtime
> error, not a fs error. Account it as such.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
Yup that's better I think. I wonder if eventually str_$FOO should
get renamed to make it crystal clear to the caller whether they are
registering a filesystem error or something else, but this fixes this
problem up for now.
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> scrub/phase1.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
> diff --git a/scrub/phase1.c b/scrub/phase1.c
> index af93d0f..82c8022 100644
> --- a/scrub/phase1.c
> +++ b/scrub/phase1.c
> @@ -174,14 +174,14 @@ _("Does not appear to be an XFS filesystem!"));
> !xfs_can_scrub_bmap(ctx) || !xfs_can_scrub_dir(ctx) ||
> !xfs_can_scrub_attr(ctx) || !xfs_can_scrub_symlink(ctx) ||
> !xfs_can_scrub_parent(ctx)) {
> - str_error(ctx, ctx->mntpoint,
> + str_info(ctx, ctx->mntpoint,
> _("Kernel metadata scrubbing facility is not available."));
> return false;
> }
>
> /* Do we need kernel-assisted metadata repair? */
> if (ctx->mode != SCRUB_MODE_DRY_RUN && !xfs_can_repair(ctx)) {
> - str_error(ctx, ctx->mntpoint,
> + str_info(ctx, ctx->mntpoint,
> _("Kernel metadata repair facility is not available. Use -n to scrub."));
> return false;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
