On 1/29/18 9:38 PM, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Specifying invalid inputs to mkfs does not break any (reasonable) laws, > so the error message should complain about invalid inputs. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Maybe not in your state ... Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> > --- > mkfs/xfs_mkfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c > index 7c9d148..6285b24 100644 > --- a/mkfs/xfs_mkfs.c > +++ b/mkfs/xfs_mkfs.c > @@ -911,7 +911,7 @@ illegal( > const char *value, > const char *opt) > { > - fprintf(stderr, _("Illegal value %s for -%s option\n"), value, opt); > + fprintf(stderr, _("Invalid value %s for -%s option\n"), value, opt); > usage(); > } > > @@ -1267,7 +1267,7 @@ illegal_option( > const char *reason) > { > fprintf(stderr, > - _("Illegal value %s for -%c %s option. %s\n"), > + _("Invalid value %s for -%c %s option. %s\n"), > value, opts->name, opts->subopts[index], > reason ? reason : ""); > usage(); > -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html