On Fri, Jan 26, 2018 at 11:34:50PM -0800, Christoph Hellwig wrote: > > - if (WARN_ON(iomap.offset > pos)) > > + if (WARN_ON(iomap.offset > pos) || WARN_ON(iomap.length == 0)) > > Btw, shouldn't this be one WARN_ON with both conditions inside? > It's not like we can spot which one it was based on the output > anyway. > > Alternatively just have two conditionals, which allows us to spot > what went wrong. Ah, right, I forgot that WARN_ON doesn't print the failing condition unlike our ASSERT. --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
