On Fri, Jan 26, 2018 at 11:00:58AM -0800, Darrick J. Wong wrote: > On Fri, Jan 26, 2018 at 04:15:46AM -0800, Christoph Hellwig wrote: > > On Tue, Jan 23, 2018 at 06:18:29PM -0800, Darrick J. Wong wrote: > > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > > > Track the number of blocks reserved in the CoW fork so that we can > > > move the quota reservations whenever we chown, and don't account for > > > CoW fork delalloc reservations in i_delayed_blks. This should make > > > chown work properly for quota reservations, enables us to fully > > > account for real extents in the cow fork in the file stat info, and > > > improves the post-eof scanning decisions because we're no longer > > > confusing data fork delalloc extents with cow fork delalloc extents. > > > > Just curious: is there any good reason we can't just have an > > i_extra_blocks field for the delayed and cow blocks? Or is there > > a place where we care about the difference between the two? > > "cow blocks" now includes real and unwritten extents sitting around in > the cow fork in addition to delalloc extents in the cow fork, and I > didn't want the field to have overlapping meanings. On a practical > level, it also means we avoid eofblocks scans on inodes that have cow > blocks but no da blocks. Oh. Duh, we have the inode tags for that. Ok, dropping this patch; will integrate the two i_delayed_blks twiddles we need into the one that fixes the quota accounting. --D > --D > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
