On Fri, Jan 26, 2018 at 04:17:16AM -0800, Christoph Hellwig wrote: > On Wed, Jan 24, 2018 at 09:26:47PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Since we now have a dedicated function for dealing with CoW allocation > > related quota updates in xfs_bmap_btalloc, we might as well refactor the > > data/attr fork quota update into its own function too. > > Any good reason not to have this merged with the cow fork side helper? > > > + /* > > + * Adjust the disk quota also. This was reserved > > + * earlier. > > + */ > > Please use the full available line length for comments. > > > + xfs_trans_mod_dquot_byino(ap->tp, ap->ip, > > + ap->wasdel ? XFS_TRANS_DQ_DELBCOUNT : XFS_TRANS_DQ_BCOUNT, > > + (long) args.len); > > I don't think we need this cast. I fixed all of these; will have a new series out soon. --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
