On Thu, Jan 11, 2018 at 07:15:52PM -0600, Eric Sandeen wrote: > On 1/5/18 7:51 PM, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Standardize how we record and report errors. > > > > > > +/* > > + * Reporting Status to the Console > > + * > > + * We aim for a roughly standard reporting format -- the severity of the > > + * status being reported, a textual description of the objecting being > > object? (I mean, I suppose it might be objecting to your horribly > corrupted filesystem?) ;) Fixed. > > + * reported, and whatever the status happens to be. > > + * > > + * Errors are the most severe and reflect filesystem corruption. > > + * Warnings indicate that something is amiss and needs the attention of > > + * the administrator, but does not constitute a corruption. Information > > + * is merely advisory. > > + */ > > + > > > > /* Program name; needed for libxcmd error reports. */ > > char *progname = "xfs_scrub"; > > > > +/* Debug level; higher values mean more verbosity. */ > > +unsigned int debug; > > + > > +/* Should we dump core if errors happen? */ > > +bool dumpcore; > > not independent of debug right, but ... *shrug* Wart from the old days. I'll gate core dumping on debug. --D > -Eric > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html