On Thu, Jan 11, 2018 at 06:04:38PM -0600, Eric Sandeen wrote: > On 1/11/18 5:59 PM, Darrick J. Wong wrote: > > On Thu, Jan 11, 2018 at 05:24:58PM -0600, Eric Sandeen wrote: > ... > > >>> + /* Non-rotational device? Throw all the CPUs. */ > >>> + rot = 1; > >>> + error = ioctl(disk->d_fd, BLKROTATIONAL, &rot); > >>> + if (error == 0 && rot == 0) > >>> + return nproc; > >> > >> I needed > >> > >> +#ifndef BLKROTATIONAL > >> +#define BLKROTATIONAL _IO(0x12,126) > >> +#endif > >> > >> to make this compile on my not /that/ ancient (?) rhel6 box ;) > > > > Hmm... well, since I don't see backporting xfs kernel scrub to 2.6.32 > > maybe xfsprogs' build system should just turn off xfs_scrub on old > > systems? > > > > In any case, I #ifdef BLKROTATIONAL'd out the entire clause. > > ok. well, other distros are making noise about using bleeding edge progs > w/ older distro kernels (hence the mkfs config file wishes) so it's probably > good to consider building against older environments. <shrug> ok I can patch it in like that... --D > Thanks, > -Eric > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
