On Thu, Jan 11, 2018 at 01:37:33PM -0600, Eric Sandeen wrote:
> The buf_fsprivate3 field has no actual use, other than a pointless
> "if it's not set, set it" in xfs_buf_item_init; nobody cares after
> that. Remove it.
>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
> libxfs/libxfs_io.h | 4 ----
> libxfs/logitem.c | 2 --
> 2 files changed, 6 deletions(-)
>
> diff --git a/libxfs/libxfs_io.h b/libxfs/libxfs_io.h
> index 5acd3df..2fce04d 100644
> --- a/libxfs/libxfs_io.h
> +++ b/libxfs/libxfs_io.h
> @@ -70,7 +70,6 @@ typedef struct xfs_buf {
> unsigned int b_recur;
> void *b_fspriv;
> void *b_transp;
> - void *b_fsprivate3;
> void *b_addr;
> int b_error;
> const struct xfs_buf_ops *b_ops;
> @@ -111,9 +110,6 @@ enum xfs_buf_flags_t { /* b_flags bits */
> #define XFS_BUF_SET_ADDR(bp,blk) ((bp)->b_bn = (blk))
> #define XFS_BUF_SET_COUNT(bp,cnt) ((bp)->b_bcount = (cnt))
>
> -#define XFS_BUF_FSPRIVATE3(bp,type) ((type)(bp)->b_fsprivate3)
> -#define XFS_BUF_SET_FSPRIVATE3(bp,val) (bp)->b_fsprivate3 = (void *)(val)
> -
> #define XFS_BUF_SET_PRIORITY(bp,pri) cache_node_set_priority( \
> libxfs_bcache, \
> (struct cache_node *)(bp), \
> diff --git a/libxfs/logitem.c b/libxfs/logitem.c
> index 0c183b5..0c50fcf 100644
> --- a/libxfs/logitem.c
> +++ b/libxfs/logitem.c
> @@ -96,8 +96,6 @@ xfs_buf_item_init(
> * the first. If we do already have one, there is
> * nothing to do here so return.
> */
> - if (XFS_BUF_FSPRIVATE3(bp, xfs_mount_t *) != mp)
> - XFS_BUF_SET_FSPRIVATE3(bp, mp);
> XFS_BUF_SET_BDSTRAT_FUNC(bp, xfs_bdstrat_cb);
> if (bp->b_fspriv != NULL) {
> lip = bp->b_fspriv;
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
