On Fri, Dec 22, 2017 at 04:43:08PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>
> Refactor xfs_scrub_bmap to use for_each_xfs_iext now that it exists.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
> fs/xfs/scrub/bmap.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>
> diff --git a/fs/xfs/scrub/bmap.c b/fs/xfs/scrub/bmap.c
> index 42fec0b..0261e11 100644
> --- a/fs/xfs/scrub/bmap.c
> +++ b/fs/xfs/scrub/bmap.c
> @@ -235,7 +235,6 @@ xfs_scrub_bmap(
> struct xfs_ifork *ifp;
> xfs_fileoff_t endoff;
> struct xfs_iext_cursor icur;
> - bool found;
> int error = 0;
>
> ifp = XFS_IFORK_PTR(ip, whichfork);
> @@ -314,9 +313,7 @@ xfs_scrub_bmap(
> /* Scrub extent records. */
> info.lastoff = 0;
> ifp = XFS_IFORK_PTR(ip, whichfork);
> - for (found = xfs_iext_lookup_extent(ip, ifp, 0, &icur, &irec);
> - found != 0;
> - found = xfs_iext_next_extent(ifp, &icur, &irec)) {
> + for_each_xfs_iext(ifp, &icur, &irec) {
> if (xfs_scrub_should_terminate(sc, &error))
> break;
> if (isnullstartblock(irec.br_startblock))
Looks good.
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
--
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
