On Wed, Jan 03, 2018 at 06:51:12PM +1100, Dave Chinner wrote: > > "Additionally we call it during the write operation, where aren't > > concerned about exposing unallocated blocks but just want to provide > > basic synchronization between a local writer and pNFS clients. mmap > > writes would also benefit from this sort of synchronization, but due > > to the tricky locking rules in the page fault path we don't bother." > > --- > > The pnfs code went into 3.20 (4.0, IIRC), whilst the XFS_MMAPLOCK > code went into 4.1. So the pnfs code was written and tested by > Christoph a long time before I added the XFS_MMAPLOCK, despite them > landing only one release apart. We've never really gone back to look > at this because there hasn't been a need until now.... I suspect we should drop the MMAPLOCK as well, but I'd need to re-read and re-test the code. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html