On Fri, Dec 22, 2017 at 05:07:34PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Since all verification errors also mark the buffer as having an error, > we can combine these two calls. Later we'll add a xfs_failaddr_t > parameter to promote the idea of reporting corruption errors and the > address of the failing check to enable better debugging reports. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > fs/xfs/libxfs/xfs_alloc.c | 20 ++++++-------------- > fs/xfs/libxfs/xfs_alloc_btree.c | 11 ++++------- > fs/xfs/libxfs/xfs_attr_leaf.c | 10 +++------- > fs/xfs/libxfs/xfs_attr_remote.c | 24 +++++++++++------------- > fs/xfs/libxfs/xfs_bmap_btree.c | 11 ++++------- > fs/xfs/libxfs/xfs_da_btree.c | 16 +++++----------- > fs/xfs/libxfs/xfs_dir2_block.c | 10 +++------- > fs/xfs/libxfs/xfs_dir2_data.c | 15 +++++---------- > fs/xfs/libxfs/xfs_dir2_leaf.c | 10 +++------- > fs/xfs/libxfs/xfs_dir2_node.c | 13 ++++--------- > fs/xfs/libxfs/xfs_dquot_buf.c | 10 +++------- > fs/xfs/libxfs/xfs_ialloc.c | 10 +++------- > fs/xfs/libxfs/xfs_ialloc_btree.c | 11 ++++------- > fs/xfs/libxfs/xfs_inode_buf.c | 3 +-- > fs/xfs/libxfs/xfs_refcount_btree.c | 11 ++++------- > fs/xfs/libxfs/xfs_rmap_btree.c | 11 ++++------- > fs/xfs/libxfs/xfs_sb.c | 10 ++++------ > fs/xfs/libxfs/xfs_symlink_remote.c | 10 +++------- > fs/xfs/xfs_buf.c | 7 ++++--- > fs/xfs/xfs_buf.h | 4 +++- > fs/xfs/xfs_error.c | 5 ++++- > fs/xfs/xfs_error.h | 2 +- > fs/xfs/xfs_trace.h | 6 +++--- > 23 files changed, 89 insertions(+), 151 deletions(-) Nice! I didn't think there was that much cleanup in this little rework :) Looks good to me. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html