> +static inline unsigned long
> +xfs_iflag_for_tag(
> + int tag)
> +{
> + switch (tag) {
> + case XFS_ICI_EOFBLOCKS_TAG:
> + return XFS_IEOFBLOCKS;
> + case XFS_ICI_COWBLOCKS_TAG:
> + return XFS_ICOWBLOCKS;
> + default:
> + ASSERT(0);
> + return 0;
> + }
> +}
I'd rather pass the flag explicitly to the functions that already
take the tag value.
Except for that the patch looks fine:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
