On Tue, Dec 19, 2017 at 07:01:12PM -0800, Darrick J. Wong wrote: > On Mon, Dec 18, 2017 at 08:11:58PM +1100, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > Very few people use the log2 based size options for various mkfs > > parameters and they just clutter up the code. Get rid of them. > > Maybe we should deprecate them for at least one release instead of > just hard breaking everyone's scripts? Yet we don't even test that these options give the right results :/ i.e. this patch does not cause any new regressions in xfstests... I know of only one person who used them, and that was a guy that did testing for us in his spare time a few years ago. Hence I'm of the opinion we should just remove them, just like we don't give people any warning of default mkfs values changing. Eric can decide what to do, but I wrote this patch after he pondered aloud on #xfs if we should just remove these options :P -Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
