On Wed, Dec 13, 2017 at 03:28:05PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > In this test we use a fixed sequence of operations in fsstress to create > some number of files and dirs and then exercise xfsdump/xfsrestore on > them. Since clonerange/deduperange are not supported on all xfs > configurations, detect if they're in fsstress and disable them so that > we always execute exactly the same sequence of operations no matter how > the filesystem is configured. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > tests/xfs/068 | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/tests/xfs/068 b/tests/xfs/068 > index 7151e28..f95a539 100755 > --- a/tests/xfs/068 > +++ b/tests/xfs/068 > @@ -43,6 +43,14 @@ trap "rm -rf $tmp.*; exit \$status" 0 1 2 3 15 > _supported_fs xfs > _supported_os Linux > > +# Remove fsstress commands that aren't supported on all xfs configs > +if $FSSTRESS_PROG | grep -q clonerange; then > + FSSTRESS_AVOID="-f clonerange=0 $FSSTRESS_AVOID" > +fi > +if $FSSTRESS_PROG | grep -q deduperange; then > + FSSTRESS_AVOID="-f deduperange=0 $FSSTRESS_AVOID" > +fi > + I'd put this inside _create_dumpdir_stress_num as it's supposed to DTRT for the dump/restore that follows. Otherwise looks fine. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
