On Thu, Dec 07, 2017 at 01:58:09PM -0500, Brian Foster wrote: > Defer AGFL block frees from deferred extent free context. This means > that extents that are deferred freed via xfs_bmap_add_free() will > add additional deferred items for AGFL block frees during completion > processing. All such items complete before xfs_defer_finish() > returns. > > Update xfs_trans_free_extent() and xfs_free_extent() to receive an > optional dfops pointer and pass it down to the AGFL fixup code via > the allocation arguments structure. Update > xfs_extent_free_finish_item() to pass along the dfops list currently > being processed by xfs_defer_finish(). All other callers pass a NULL > dfops and so do not change behavior. > > Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx> > --- > fs/xfs/libxfs/xfs_alloc.c | 9 ++++++--- > fs/xfs/libxfs/xfs_alloc.h | 5 +++-- > fs/xfs/libxfs/xfs_ialloc_btree.c | 2 +- > fs/xfs/libxfs/xfs_refcount_btree.c | 2 +- > fs/xfs/libxfs/xfs_rmap.c | 2 +- > fs/xfs/xfs_extfree_item.c | 2 +- > fs/xfs/xfs_fsops.c | 2 +- > fs/xfs/xfs_trans.h | 3 ++- > fs/xfs/xfs_trans_extfree.c | 7 ++++--- > 9 files changed, 20 insertions(+), 14 deletions(-) Rather than passing the dfops structure around, I'm starting to wonder it it makes more sense to attach it to the struct xfs_trans we pass around to all these functions? That would mean it doesn't need to be manually plumbed into any of this code - it would be directly available in any transaction context that has a dfops associated with it. That would mean all agfl fixups would be able to be deferred without modifying any of the intermediate code paths as all allocation/free transactions require a dfops structure.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
