Re: [PATCH] xfs: make iomap_begin functions trim iomaps consistently

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 06, 2017 at 10:38:07AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> Historically, the XFS iomap_begin function only returned mappings for
> exactly the range queried, i.e. it doesn't do XFS_BMAPI_ENTIRE lookups.
> The current vfs iomap consumers are only set up to deal with trimmed
> mappings.  xfs_xattr_iomap_begin does BMAPI_ENTIRE lookups, which is
> inconsistent with the current iomap usage.  Remove the flag so that both
> iomap_begin functions behave the same way.
> 
> FWIW this also fixes a behavioral regression in xattr FIEMAP that was
> introduced in 4.8 wherein attr fork extents are no longer trimmed like
> they used to be.

I would still prefer to trim in the iomap code.  But I'll need to find
some time to look into that, so until then here is my reluctant ACK:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux