Re: [PATCH 1/4] xfs: add scrub to XFS_BUILD_OPTIONS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 01, 2017 at 04:12:34PM -0600, Eric Sandeen wrote:
> Advertise this config option along with the others.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> diff --git a/fs/xfs/xfs_super.h b/fs/xfs/xfs_super.h
> index fcc5dfc..8cee8e8 100644
> --- a/fs/xfs/xfs_super.h
> +++ b/fs/xfs/xfs_super.h
> @@ -44,6 +44,12 @@
>  # define XFS_REALTIME_STRING
>  #endif
>  
> +#ifdef CONFIG_XFS_ONLINE_SCRUB
> +# define XFS_SCRUB_STRING	"scrub, "
> +#else
> +# define XFS_SCRUB_STRING
> +#endif

I don't mind this addition to the build options, though I had pictured
scrub becoming an integral part of xfs some day and not remaining a
configurable option.

That said I haven't evaluated how much scrub bloats up xfs nor do I know
if the kernel tinyfication people would actually want to turn it off??

(For my part I prefer it some day not be Kconfig option so that it won't
bitrot ala CONFIG_XFS_RT=y.)

--D

> +
>  #ifdef DEBUG
>  # define XFS_DBG_STRING		"debug"
>  #else
> @@ -54,6 +60,7 @@
>  #define XFS_BUILD_OPTIONS	XFS_ACL_STRING \
>  				XFS_SECURITY_STRING \
>  				XFS_REALTIME_STRING \
> +				XFS_SCRUB_STRING \
>  				XFS_DBG_STRING /* DBG must be last */
>  
>  struct xfs_inode;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux