Hi Darrick, this looks generally good to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx> But I have a few nitpicks below: > + /* > + * We're finishing the defer_ops that accumulated as a result of > + * recovering unfinished intent items during log recovery. We > + * reserve an itruncate transaction because it is the largest > + * permanent transaction type. Since we're the only user of the > + * fs right now, take 93% of the available free blocks. Use > + * weird math to avoid a 64-bit division. > + */ Those magic 93% are 15/16th, maybe better to write it that way :) That being said / 16 still is a 64-bit division, and I'm pretty sure we'll run into an old gcc on some weird architecture that will not turn it into a shift, so better write it as a shift to start with. > + freeblks = percpu_counter_sum(&mp->m_fdblocks); > + resblks = min_t(s64, UINT_MAX, freeblks); Didn't I just got called out for using u* types? The same applies to s*, so use int64_t here to be consistent. > + /* > + * NOTE: If your intent processing routine can create > + * more deferred ops, you /must/ attach them to the > + * dfops in this routine or else those subsequent > + * intents will get replayed in the wrong order! > + */ Please use up all available 80 characters for your comments. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
