On Fri, Nov 17, 2017 at 12:35:43PM -0800, Dan Williams wrote: > On Fri, Nov 17, 2017 at 12:25 PM, Ross Zwisler > <ross.zwisler@xxxxxxxxxxxxxxx> wrote: > > Add support for a new -S flag to xfs_io's mmap command. This opens the > > mapping with the (MAP_SYNC | MAP_SHARED_VALIDATE) flags instead of the > > standard MAP_SHARED flag. > > > > Signed-off-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx> > > Suggested-by: Dave Chinner <david@xxxxxxxxxxxxx> > > --- > > configure.ac | 1 + > > include/builddefs.in | 1 + > > include/linux.h | 5 +++++ > > io/io.h | 1 + > > io/mmap.c | 19 ++++++++++++++----- > > m4/package_libcdev.m4 | 16 ++++++++++++++++ > > man/man8/xfs_io.8 | 6 +++++- > > 7 files changed, 43 insertions(+), 6 deletions(-) > > > > diff --git a/configure.ac b/configure.ac > > index cb23fb8..7153c9f 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -162,6 +162,7 @@ AC_HAVE_FSETXATTR > > AC_HAVE_MREMAP > > AC_NEED_INTERNAL_FSXATTR > > AC_HAVE_GETFSMAP > > +AC_HAVE_MAP_SYNC > > > > if test "$enable_blkid" = yes; then > > AC_HAVE_BLKID_TOPO > > diff --git a/include/builddefs.in b/include/builddefs.in > > index 1d454b6..78b71fe 100644 > > --- a/include/builddefs.in > > +++ b/include/builddefs.in > > @@ -114,6 +114,7 @@ HAVE_FSETXATTR = @have_fsetxattr@ > > HAVE_MREMAP = @have_mremap@ > > NEED_INTERNAL_FSXATTR = @need_internal_fsxattr@ > > HAVE_GETFSMAP = @have_getfsmap@ > > +HAVE_MAP_SYNC = @have_map_sync@ > > > > GCCFLAGS = -funsigned-char -fno-strict-aliasing -Wall > > # -Wbitwise -Wno-transparent-union -Wno-old-initializer -Wno-decl > > diff --git a/include/linux.h b/include/linux.h > > index 6ce344c..4ee03ed 100644 > > --- a/include/linux.h > > +++ b/include/linux.h > > @@ -327,4 +327,9 @@ fsmap_advance( > > #define HAVE_GETFSMAP > > #endif /* HAVE_GETFSMAP */ > > > > +#ifndef HAVE_MAP_SYNC > > +#define MAP_SYNC 0x80000 > > Hmm, this is the x86 specific value of MAP_SYNC. I think it would be > better to define MAP_SYNC to zero in this case and check for MAP_SYNC > == 0 at run time. Ah, so instead of defining MAP_SYNC if the proper headers aren't installed, set to 0 and disallow the -S option? Fair enough. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
