On 11/9/17 1:26 PM, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx>
>
> This results in default case which will display the error message
> that command is not found. This is required for xfs_io builds which
> did not support pwritev and an attempt is made to use -V.
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx>
> ---
> io/pwrite.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/io/pwrite.c b/io/pwrite.c
> index 1c5dfca1..5f149a68 100644
> --- a/io/pwrite.c
> +++ b/io/pwrite.c
> @@ -312,6 +312,7 @@ pwrite_f(
> case 'u':
> uflag = 1;
> break;
> +#ifdef HAVE_PWRITEV
> case 'V':
> vectors = strtoul(optarg, &sp, 0);
> if (!sp || sp == optarg) {
> @@ -320,6 +321,7 @@ pwrite_f(
> return 0;
> }
> break;
> +#endif
> case 'w':
> wflag = 1;
> break;
> @@ -334,6 +336,7 @@ pwrite_f(
> }
> break;
> default:
> + printf(_("command -%c not supported\n"), c);
> return command_usage(&pwrite_cmd);
> }
> }
I think this is slightly better:
default:
/* Handle ifdef'd-out options above */
if (c != '?')
printf(_("%s: command -%c not supported\n"), argv[0], c);
return command_usage(&pwrite_cmd);
}
so we don't get the message for a completely bogus (not in getopt string)
argument on top of the one getopt already gives us.
I can do it on the way in.
Other than that,
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Thanks,
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
