On Thu, Nov 2, 2017 at 1:04 PM, Eric Sandeen <sandeen@xxxxxxxxxxx> wrote: > On 10/26/17 12:28 PM, Luis R. Rodriguez wrote: >> ./configure will leave traces of a complaint on config.log when >> _BSD_SOURCE is defined but not _DEFAULT_SOURCE. _BSD_SOURCE is >> deprecated so if defining _BSD_SOURCE also define _DEFAULT_SOURCE. >> >> From config.log: >> /usr/include/features.h:183:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp] > > Ok. Or perhaps a more clear rationale is the preadv(5) manpage > itself: > > preadv(), pwritev(): > since glibc 2.19: > _DEFAULT_SOURCE > Glibc 2.19 and earlier: > _BSD_SOURCE > > But this is just a feature test macro in a configure script. > > What about the code itself, how do we handle this when we > actually use preadv() in the codebase? Its not clear to me what the issue would be by defining this extra _DEFAULT_SOURCE when _BSD_SOURCE is defined. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
