On Thu, Nov 02, 2017 at 07:49:42PM +0100, Christoph Hellwig wrote:
> On Tue, Oct 31, 2017 at 03:02:34PM -0700, Darrick J. Wong wrote:
> > > + struct xfs_iext_cursor ext;
> >
> > I was expecting an extent map cursor to have 'cur' in the name --
> > 'ext' misleads me into thinking that 'ext' is an actual extent.
> >
> > struct xfs_iext_cursor *icur;
> >
> > Also, xfs_iext_insert names its cursor parameter *cur, so why ext here?
>
> I started out with cur, but in most bmap routines we already have the
> btree cursor named cur, so I had to look for something else. I could
> probably change to icur, but that will be a heck of an annoying rebase..
How many more patches do you have after the ones you've already sent?
I /do/ have the ability to do evil things like sed -e 's/ext,/icur,/g'
to the patches and re-stuff them in the git branch. I probably wouldn't
bother with the ones already named 'cur', it's just the 'ext' ones that
increase my cognitive impedance.
--D
> > For now I'm going to assume that xfs_iext_{first,last,next,prev} will
> > actually do something with the ifp parameter in the near future.
>
> Yes, good assumption.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
