On Tue, Oct 31, 2017 at 05:16:23PM -0700, Darrick J. Wong wrote: > On Wed, Nov 01, 2017 at 10:22:33AM +1100, Dave Chinner wrote: > > On Tue, Oct 31, 2017 at 12:31:28PM -0700, Darrick J. Wong wrote: > > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > > > Move the error injection tag names into a libxfs header so that we can > > > share it between kernel and userspace. > > > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Simple enough, but there's an admin problem with this patch. > > > > > new file mode 100644 > > > index 0000000..0cc1c05 > > > --- /dev/null > > > +++ b/fs/xfs/libxfs/xfs_errortag.h > > > @@ -0,0 +1,106 @@ > > > +/* > > > + * Copyright (C) 2017 Oracle. All Rights Reserved. > > > + * > > > + * Author: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > This isn't actually true. You're moving a bunch of code from > > fs/xfs/xfs_error.h that is under: > > > > * Copyright (c) 2000-2002,2005 Silicon Graphics, Inc. > > * All Rights Reserved. > > > > Moving code into a new file does not reassign the copyright on the > > code to a new owner. Hence I think this is the appropriate way to > > record the copyrights on this new file: > > > > * Copyright (c) 2000-2002,2005 Silicon Graphics, Inc. > > * Copyright (C) 2017 Oracle. > > * All Rights Reserved. > > > > And there's no real need for author tags as we've got that > > information in the git repo.... > > Works for me. I wasn't really sure whose copyright really applied to > changes like this -- the one in the source file? The person who creates > the new file? Every last person who ever touched it? etc. It's not clear cut, and IANAL. My basic "try not to get into trouble" rule is that when copying a significant chunk of code from a file with a copyright notice is to preserve that notice with the new copy of the code... > They don't teach this stuff in maintainer school. :/ Nope, that they don't. I'm careful about this stuff mainly because of the fact that the Linux XFS code has a different history to almost all the other Linux code. And that other code with a similar lineage (i.e. has a SGI/Irix heritage) came under the spotlight in the SCO vs IBM copyright war.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
