Hi all, These are several minor fixes that fell out of both Zorro's[1] and Darrick's[2] recent reports. Patches 1 and 2 address the log cycle underflow problem on filesystems with logs that are sized too small by mfks. Patch 3 drains the lru after log recovery to prevent buffers from lingering with NULL verifier ops after log recovery completes (on v4 fs'). Patch 4 adds a mount time check to enforce that the total log buffer size does not exceed 1/2 the physical log size, as suggested by Dave[3]. Note that patch 4 is RFC for a couple reasons. First, I don't quite grok where the 1/2 log size restriction comes from, so I'd like to be able to at least include a more descriptive commit log on that. Second, this patch causes a couple xfstests failures (xfs/030, xfs/057) when testing with larger log buf sizes on filesystems that otherwise have sufficiently sized logs (i.e., logbufs=8,logbsize=256k w/ a 3MB log), so I'm not totally convinced this restriction is necessary (or 50% is the right restriction) without some further feedback on that. For example, should we always enforce this restriction as the current patch does, or only when the log happens to be under the (expected) minimum size? Thoughts, reviews, flames appreciated. Brian [1] https://marc.info/?l=linux-xfs&m=150674214217044&w=2 [2] https://marc.info/?l=linux-xfs&m=150792056128414&w=2 [3] https://marc.info/?l=linux-xfs&m=150819276824933&w=2 Brian Foster (4): xfs: sanity check log record range parameters xfs: fix log block underflow during recovery cycle verification xfs: drain the buffer LRU on mount xfs: enforce a maximum total iclog buffer size fs/xfs/xfs_log.c | 21 +++++++++++++++++++++ fs/xfs/xfs_log_recover.c | 13 ++++++++++--- 2 files changed, 31 insertions(+), 3 deletions(-) -- 2.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
